datastores: collectSecondaryPositions discards the First() result — blank positions silently appended on outage

[SyniRon]

Found during the wave-2 silent-failure review (pre-existing, shared by both stacks — not a parity break).

datastores/mysql.go:205 (collectSecondaryPositions, feeds position search via generateLiteProtoProfile at mysql.go:296): ds.Db.First(&position, id) — the result/error is discarded entirely. A connection failure, context timeout, or missing row silently appends a blank position (positionTitle:"", positionId:0) into a 200 response. Hides every error class; a user cannot distinguish degradation from real data.

Same pattern at mysql.go:404 (collectS1UniformsSecondaryPositions, S1 uniforms route).

Fix shape: check the error; on failure propagate (500 via the route's outage path) rather than emitting fabricated members. Note any fix must respect the golden corpus — error paths are witnessed live, not by goldens, so this is behavior-improving and needs a ruling against PRD #112's parity discipline before changing the happy-path-with-partial-outage shape.

[SyniRon]

This was generated by AI during triage.

Maintainer ruling (2026-06-06, recorded during the pre-#131 triage): the outage shape is ruled parity — the new stack keeps serving exactly what prod has always served (blank position appended on a 200 during partial outage). The body's proposed shape change (propagate → 500 via the outage path) will not land.

The fix rides #134 as an observability change: the discarded First() result becomes visible (logged/metered) without altering the degrade shape consumers see. Covers both sites named in the body (collectSecondaryPositions at mysql.go:205 and collectS1UniformsSecondaryPositions at mysql.go:404).

Labels: ready-for-agent (the ruling resolves the open design question) + blocked (sequenced into #134's wave).