JSON Manager crossed request issue?

[D8H]

Shouldn't the callbacks be stacked when a file is being read?

GDevelop/GDJS/Runtime/jsonmanager.ts

Lines 111 to 115 in bc606ed

	// Don't fetch again an object that is already in memory
	if (this._loadedJsons[resourceName]) {
	callback(null, this._loadedJsons[resourceName]);
	return;
	}

Because when loadJson is called for the same file at 2 places. This could happens:

• Alice asks the json
• Bob asks the json
• Alice's parsed json is added to _loadedJsons
• Alice gets call-backed
• Bob's parsed json is added to _loadedJsons over Alice one
• Bob gets call-backed

I guess that when there is already a callback for a given file, the second request should only adds the callback to the list instead of loading the file again.

[4ian]

You're correct, a pending list (with proper cleaning if the loading failed I guess) is needed to have a 100% correct behavior including the case you're mentioning.