Skip to content

[Bug] MakeROM - major version limit #169

Description

@xxmichibxx

Hello, I've encountered a bug where MakeROM where the minor version number is completely ignored and resets to 0, but only when building a title with a major/minor version of 7 or higher.

Steps to reproduce:
I tried setting the version to 7.7.0 using the individual parameters:
makerom.exe -f cia -ignoresign -target p -o "0004000E0011C500.cia" -i "tmp.7.0 W.0.ncch:0:0" -major 7 -minor 7 -micro 0

I also tried using the combined version parameter for the same target version:
makerom.exe -f cia -ignoresign -target p -o "0004000E0011C500.cia" -i "tmp.7.0 W.0.ncch:0:0" -ver 7280

Expected Result:
The output file should have version 7.7.0 (which mathematically corresponds to the title version 7280).

Actual Result:
The output file always ends up with version 7.0.0 (title version 7168).

Because the parameters work flawlessly for versions below 7.0.0, this seems to be an issue specifically triggered by the major version value hitting 7 or higher. Could you please look into this? Thank you!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions